Feat: Enable CUDA-enabled images and multi-arch builds #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
reviewed
Nov 6, 2025
run-image/Dockerfile
Outdated
Comment on lines
4
to
7
| ARG cnb_uid=1001 | ||
| ARG cnb_gid=1001 | ||
| ENV CNB_USER_ID=${cnb_uid} | ||
| ENV CNB_GROUP_ID=${cnb_gid} |
Member
There was a problem hiding this comment.
While I understand that the user id during the build phase is 1001, we should keep user 1000:1000 for when we run the image.
SalimKayal
force-pushed
the
feat/cuda-images
branch
from
4d2acf0 to
1cfd725
Compare
leafty
reviewed
Nov 10, 2025
run-image/Dockerfile
Outdated
| ENV CNB_USER_ID=${cnb_run_uid} | ||
| ENV CNB_GROUP_ID=${cnb_run_gid} | ||
|
|
||
| RUN |
run-image/Dockerfile
Outdated
|
|
||
| USER $user_id | ||
| WORKDIR /home/renku | ||
| RUN (userdel $(getent passwd ${cnb_uid}|cut -d: -f1) || true) && \ |
Member
There was a problem hiding this comment.
Should we also delete the groups 1000 and 1001 if they exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant enhancements to our Dockerfile and build process, allowing for the seamless integration of CUDA-enabled images and improving multi-architecture support.
The core changes involve updating the Dockerfile to support using a single image as both a build image for our builder and as a runtime image. This refactoring streamlines our image management and ensures consistency across different stages of the build and deployment pipeline.
To facilitate these changes, several new dependencies have been added. These additions are crucial for Paketo's Python buildpack, as they provide the necessary tools and libraries for successfully building Python applications within the updated environment. This ensures that our Python projects continue to build correctly while leveraging the new image capabilities.
With these updates, we can now utilize CUDA-enabled images, opening up possibilities for accelerated computing tasks within our environments.