Skip to content

Conversation

@olevski
Copy link
Member

@olevski olevski commented Dec 19, 2025

The regular python k8s client has issues/conflicts with the update of urllib. And we still use that for the clients for quotas and priority classes.

I switched these to async and to kr8s.

Also I made it so that we can create quotas and priority classes in any remote cluster that is connected - not just ours.

/deploy extra-values=enableInternalGitlab=false

@olevski olevski requested review from a team, SalimKayal and sgaist as code owners December 19, 2025 00:16
@olevski olevski marked this pull request as draft December 19, 2025 00:16
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1147.dev.renku.ch

Copy link
Collaborator

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the code changes, and the test errors, it seems that DummyCoreClient has been modified but not commited.

@olevski olevski force-pushed the fix-urllib-k8s-client-conflicts branch 2 times, most recently from 0e811ba to 1401bbe Compare December 19, 2025 15:58
@olevski olevski force-pushed the fix-urllib-k8s-client-conflicts branch from 8fb10bc to 20e6437 Compare January 4, 2026 23:19
@coveralls
Copy link

coveralls commented Jan 4, 2026

Pull Request Test Coverage Report for Build 20754585112

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 219 of 252 (86.9%) changed or added relevant lines in 11 files are covered.
  • 10 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.3%) to 86.368%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/crc/models.py 4 5 80.0%
components/renku_data_services/crc/orm.py 4 5 80.0%
components/renku_data_services/secrets/core.py 2 3 66.67%
components/renku_data_services/k8s/db.py 23 26 88.46%
components/renku_data_services/k8s/models.py 46 50 92.0%
components/renku_data_services/crc/db.py 23 29 79.31%
components/renku_data_services/k8s/clients.py 89 106 83.96%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/api/classes/data_service.py 1 62.61%
components/renku_data_services/crc/orm.py 1 96.99%
components/renku_data_services/k8s/clients.py 1 87.08%
bases/renku_data_services/secrets_storage_api/dependencies.py 1 94.29%
components/renku_data_services/secrets/core.py 1 86.3%
components/renku_data_services/session/models.py 1 94.17%
components/renku_data_services/k8s/db.py 1 90.37%
components/renku_data_services/base_api/error_handler.py 1 91.3%
components/renku_data_services/k8s/config.py 2 88.0%
Totals Coverage Status
Change from base Build 20751744757: 0.3%
Covered Lines: 24431
Relevant Lines: 28287

💛 - Coveralls

@olevski olevski requested a review from sgaist January 5, 2026 04:41
@olevski olevski marked this pull request as ready for review January 5, 2026 04:41
@olevski
Copy link
Member Author

olevski commented Jan 5, 2026

The CI deployments are broken. That is why the acceptance tests are failing.

return json.dumps(data, sort_keys=True, default=str)


class KindCluster(AbstractContextManager):
Copy link
Member Author

@olevski olevski Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KindCluster remains the same it just got moved to another file at a higher level so more tests can use it.
It moved from test/bases/renku_data_services/data_api/utils.py to test/utils.py

@olevski olevski requested a review from sgaist January 6, 2026 04:55
@olevski olevski force-pushed the fix-urllib-k8s-client-conflicts branch from 20e6437 to c56782b Compare January 6, 2026 16:21
@olevski olevski enabled auto-merge (squash) January 6, 2026 16:22
@olevski olevski merged commit 2c01043 into main Jan 6, 2026
40 of 46 checks passed
@olevski olevski deleted the fix-urllib-k8s-client-conflicts branch January 6, 2026 16:54
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 6, 2026

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants