-
Notifications
You must be signed in to change notification settings - Fork 2
fix: only use kr8s for k8s clients #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can access the deployment of this PR at https://renku-ci-ds-1147.dev.renku.ch |
sgaist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the code changes, and the test errors, it seems that DummyCoreClient has been modified but not commited.
0e811ba to
1401bbe
Compare
8fb10bc to
20e6437
Compare
Pull Request Test Coverage Report for Build 20754585112Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
The CI deployments are broken. That is why the acceptance tests are failing. |
| return json.dumps(data, sort_keys=True, default=str) | ||
|
|
||
|
|
||
| class KindCluster(AbstractContextManager): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KindCluster remains the same it just got moved to another file at a higher level so more tests can use it.
It moved from test/bases/renku_data_services/data_api/utils.py to test/utils.py
20e6437 to
c56782b
Compare
|
Tearing down the temporary RenkuLab deployment for this PR. |
The regular python k8s client has issues/conflicts with the update of urllib. And we still use that for the clients for quotas and priority classes.
I switched these to async and to kr8s.
Also I made it so that we can create quotas and priority classes in any remote cluster that is connected - not just ours.
/deploy extra-values=enableInternalGitlab=false