Skip to content

Conversation

@andre-code
Copy link
Contributor

@andre-code andre-code commented Jun 5, 2025

PR to update the background used in the login and registration forms.

Screenshot 2025-06-11 at 13 06 45 Screenshot 2025-06-11 at 13 06 33

@andre-code andre-code force-pushed the andrea/update-bg-login branch from 7e0d263 to a2b1fec Compare June 5, 2025 08:20
@andre-code andre-code marked this pull request as ready for review June 9, 2025 20:11
@andre-code andre-code requested a review from ciyer June 10, 2025 07:09
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I deployed these changes in a full deployment, and it looks good:

SwissDataScienceCenter/renku#4045

@andre-code andre-code merged commit 86f7e64 into master Jun 16, 2025
1 check passed
@@ -1,4 +1,4 @@
FROM keycloak/keycloak:20.0.1
FROM keycloak/keycloak:26.0.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be OK to add this breaking change and release it as a patch version of the theme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, not ok - looks to be causing problems atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants