updating gulp-filter to 4.0.0 causes map and rev failure

[Endellur]

Not really an issue with the current version, but when I try to update all the dependencies for npm and bower I am able to move everything to current except gulp-filter. When I upgrade that from 3.0.1 to 4.0.0, rev and map stop working. I found this issue that might be related:

sindresorhus/gulp-filter#62

I am new to gulp and wasn't able to find the issue quickly so I thought I would enter a case and let those who are more skilled with gulp take a look. Thanks.

[piu130]

For me it works. Which task is the one that fails?
3.0.1 -> 4.0.0 means major release corresponding to SemVer so there should be breaking changes.
Can you post some errors?

[Endellur]

No tasks are failing, but when the build finishes the files have not been revisioned, there are no maps and the files are not minified. If I change back to 3.0.1 it works fine.

[mzellho]

@mykbaker here's how I got it working with 4.0.0

in build.js, update the $.filter paths like this:

var htmlFilter = $.filter(path.join(conf.paths.tmp, '/serve/*.html'), {restore: true});
var jsFilter = $.filter(path.join(conf.paths.tmp, '/serve/**/*.js'), {restore: true});
var cssFilter = $.filter(path.join(conf.paths.tmp, '/serve/**/*.css'), {restore: true});

HTH,
Max

[Endellur]

@mzellhofer that worked great, thanks.

[Swiip]

That's nice, could one of you make a PR with that?

[mzellho]

I would love to, but I am on windows at the moment and somehow I cannot get your tests running. I should be able to switch to linux in the evening and will try again. I anyways pushed the changes to here