Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Issue 183 #632

Merged
merged 10 commits into from
Apr 22, 2021
Merged

Issue 183 #632

merged 10 commits into from
Apr 22, 2021

Conversation

fassko
Copy link
Member

@fassko fassko commented Apr 21, 2021

Closes #631

@hal-codebot
Copy link

hal-codebot commented Apr 21, 2021

1 Warning
⚠️ Looks like you're editing a draft! 🤓
Don't forget to review our style guide and publish the issue when you're finished.

Proselint found issues

_drafts/2021-04-22-issue-183.md

Line Message Severity
54 Needless variant. 'extendable' is the preferred form. warning
54 Needless variant. 'extendable' is the preferred form. warning
54 Needless variant. 'extendable' is the preferred form. warning
60 No hyphen is necessary in phrasal adjectives with an adverb ending in -ly, unless the -ly adverb is part of a longer phrase warning
66 Inconsistent spacing after period (1 vs. 2 spaces). warning
66 Inconsistent spacing after period (1 vs. 2 spaces). warning
74 Needless variant. 'extendable' is the preferred form. warning
74 Needless variant. 'extendable' is the preferred form. warning
74 Needless variant. 'extendable' is the preferred form. warning
76 Needless variant. 'extendable' is the preferred form. warning
87 Inconsistent spacing after period (1 vs. 2 spaces). warning
87 Inconsistent spacing after period (1 vs. 2 spaces). warning

Generated by 🚫 Danger

jeroenleenarts
jeroenleenarts previously approved these changes Apr 21, 2021
Copy link
Collaborator

@jeroenleenarts jeroenleenarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a few minor tweaks, doubles spaces and such.

@jeroenleenarts
Copy link
Collaborator

@fassko Ready when this pull request is to send it out. :) Let's hope @JaredHalpern and @morqon have some time to do their review.

It is a good workflow to have so many eyes on the content before sending it. 👍

JaredHalpern
JaredHalpern previously approved these changes Apr 22, 2021
Copy link
Member

@JaredHalpern JaredHalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

jeroenleenarts
jeroenleenarts previously approved these changes Apr 22, 2021
@morqon
Copy link
Member

morqon commented Apr 22, 2021

Adding some changes now, hope it's not too late! ☺️

@fassko
Copy link
Member Author

fassko commented Apr 22, 2021

@morqon No, right on time, thanks! :)

@morqon morqon dismissed stale reviews from jeroenleenarts and JaredHalpern via baab1a2 April 22, 2021 15:54
Copy link
Member

@morqon morqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some very minor changes this week, to the intro text, and a few small fixes in the link list. Hope that helps!

@fassko fassko merged commit 37e5aa8 into main Apr 22, 2021
@fassko fassko deleted the issue_183 branch April 22, 2021 16:07
@fassko
Copy link
Member Author

fassko commented Apr 22, 2021

Thank you @jeroenleenarts @JaredHalpern and @morqon ! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[183] Issue #183 - April 22, 2021
5 participants