Linux builds #607
Linux builds #607
Conversation
| /// Currently supported build platforms | ||
| static var allActive: [Self] { | ||
| [.ios, .macosSpm, .macosXcodebuild, .tvos, .watchos] | ||
| [.ios, .macosSpm, .macosXcodebuild, .linux, .tvos, .watchos] |
There was a problem hiding this comment.
This determines the platform order in the build matrix on the build index page. I was thinking behind iOS and macOS but before tvOS & watchOS is a good place for it to appear.
|
This is ready to go but leaving it in Draft so we can coordinate merge and deploy. |
| } | ||
|
|
||
| var cells: [BuildResult<PlatformCompatibility>] { [ios, macos, tvos, watchos] } | ||
| var cells: [BuildResult<PlatformCompatibility>] { [ios, macos, linux, tvos, watchos] } |
There was a problem hiding this comment.
This determines the order of the table columns on the package show page. Ideally those two were more tightly coupled or had the same source but that's not a trivial task due to different aggregation. Probably not worth losing sleep over unless we see a huge influx of platforms.
There was a problem hiding this comment.
Yea I think this is fine, and I think I agree with the order. The only other option would be to put Linux on the right-hand side as it's quite distinct. I'm happy with it here though.
|
Off we go then :) |
2 participants
Fixes #606
What will happen when we merge this?
NB: Apparently the platform section on the package page is not driven by the(now fixed)allActiveproperty. (The snapshots for PackageShow are unchanged.) This is obviously purely a display issue. We can either hold off on this PR while we fix this to make it a part of it or go ahead and start processing while we update the page.