This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current layout has a small issue on big screens. The max width is 1280px, but the navigation on the right side should take 20% of the view port. This works well for small screens, but starting from a certain screen size this logic shrinks the available space of the main content.
Video of the behavior:
https://user-images.githubusercontent.com/245433/115612888-0bddd100-a2ec-11eb-894f-6e616ee086f9.mov
With this change, we change the logic so the nav bar can take at most 20% of the view port. Because of this, the design still works on small screens and limits the size of the nav bar. But it also works for big screens, because the nav bar does not take space which it does not need.
Video of the new behavior:
https://user-images.githubusercontent.com/245433/115613551-d08fd200-a2ec-11eb-92f6-465262eba914.mov
But this also has the side effect that the width of the nav bar is now variable. This means that the size and position of the nav bar can "jump" when navigating between pages. If this behavior is not acceptable, then we need to come up with a more sophisticated solution.