Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added solution to issue with query string parameters breaking the acl… #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hacorbin
Copy link

… check

@hacorbin
Copy link
Author

In my specific scenario, I use acl.prefix = '/api', and the acl check worked great unless my route looked like this: '/api/users?type=admin' (for example). In that case, the "resource" it matched was "users?type=admin", which obviously wasn't in the acl.yml. By using req.path instead of req.baseUrl, this can be remedied. I tested this code with and without acl.prefix set, and with and without a router middleware for '/api'. All versions were tested with passport-jwt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant