"Remove redundant code from different files"

Several parts of the code have been removed from different files including Sample.AspNetCore/PaymentHelper.cs, PaymentOrderRequestBuilder.cs, PaymentOrderTests.cs, HttpClientExtensionsTests.cs, DictionaryLinkRelationTValueConverter.cs, Order.cs, and PaymentOrderCaptureRequest.cs. This refactoring aims to trim down the codebase to just the parts that are necessary and increase its maintainability.

src/Samples/Sample.AspNetCore/Models/Order.cs

@@ -14,6 +14,4 @@ public class Order
     public Uri PaymentLink { get; set; }
 
     public Uri PaymentOrderLink { get; set; }
-
-    // public PaymentInstrument Instrument { get; set; }
 }

src/SwedbankPay.Sdk.Infrastructure/JsonSerialization/Converters/DictionaryLinkRelationTValueConverter.cs

@@ -15,12 +15,11 @@ public override bool CanConvert(Type typeToConvert)
 
     public override JsonConverter? CreateConverter(Type typeToConvert, JsonSerializerOptions options)
     {
-        Type keyType = typeToConvert.GetGenericArguments()[0];
-        Type valueType = typeToConvert.GetGenericArguments()[1];
+        var keyType = typeToConvert.GetGenericArguments()[0];
+        var valueType = typeToConvert.GetGenericArguments()[1];
 
-        JsonConverter converter = (JsonConverter)Activator.CreateInstance(
-            typeof(CustomPaymentOrderOperationsConverter).MakeGenericType(
-                new Type[] { keyType, valueType }),
+        var converter = (JsonConverter)Activator.CreateInstance(
+            typeof(CustomPaymentOrderOperationsConverter).MakeGenericType(keyType, valueType),
             BindingFlags.Instance | BindingFlags.Public,
             binder: null,
             args: new object[] { options },

src/SwedbankPay.Sdk.Tests/Json/LinkRelationTests.cs

@@ -1,9 +1,7 @@
 using System.Text.Json;
 
 using SwedbankPay.Sdk.Infrastructure;
-using SwedbankPay.Sdk.Infrastructure.JsonSerialization;
 using SwedbankPay.Sdk.Infrastructure.PaymentOrder;
-using SwedbankPay.Sdk.PaymentOrder;
 
 namespace SwedbankPay.Sdk.Tests.Json;
 
@@ -14,14 +12,14 @@ public class LinkRelationTests
     public void A()
     {
         var linkRelation = new LinkRelation("name", "value");
-        var serialize = JsonSerializer.Serialize(linkRelation);
+        JsonSerializer.Serialize(linkRelation);
     }
 
     [Fact]
     public void B()
     {
         var httpOperation = new HttpOperation(new Uri("https://www.google.com", UriKind.RelativeOrAbsolute), new LinkRelation("name", "value"), "GET", "text/html");
-        var serialize = JsonSerializer.Serialize(httpOperation);
+        JsonSerializer.Serialize(httpOperation);
     }
 
     [Fact]
@@ -33,7 +31,7 @@ public void C()
             httpOperation
         };
 
-        var serialize = JsonSerializer.Serialize(operationList);
+        JsonSerializer.Serialize(operationList);
     }
 
     [Fact]
@@ -45,6 +43,6 @@ public void D()
             httpOperation
         };
         var paymentOrderOperations = new PaymentOrderOperations(operationList, new HttpClient());
-        var serialize = JsonSerializer.Serialize(paymentOrderOperations, Infrastructure.JsonSerialization.JsonSerialization.Settings);
+        JsonSerializer.Serialize(paymentOrderOperations, Infrastructure.JsonSerialization.JsonSerialization.Settings);
     }
 }