Skip to content

Comments

修复 Brak 自定义通知 url 结构#1437

Merged
Zeyi-Lin merged 2 commits intoSwanHubX:mainfrom
h27539:fix-Bark_URL
Feb 3, 2026
Merged

修复 Brak 自定义通知 url 结构#1437
Zeyi-Lin merged 2 commits intoSwanHubX:mainfrom
h27539:fix-Bark_URL

Conversation

@h27539
Copy link
Contributor

@h27539 h27539 commented Feb 1, 2026

修复 issue #1436

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @h27539, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决一个关于自定义通知 URL 结构的问题。通过修改通知发送逻辑,确保生成的 URL 格式正确,从而修复了 #1436 中描述的通知发送失败问题。

Highlights

  • 通知URL结构修复: 调整了 send_notification 方法中自定义通知 URL 的构建逻辑,确保 URL 始终以斜杠结尾,不再自动添加 /push 路径。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这个 PR 旨在修复 Bark 自定义通知的 URL 结构,但目前的修改似乎会破坏默认的 Bark 通知功能。新的逻辑移除了向 URL 末尾添加 /push 的部分,这会导致向错误的端点(例如 https://api.day.app/ 而不是 https://api.day.app/push)发送请求。我建议恢复之前的逻辑,并提供了一个更简洁的实现方式。请查看我的具体评论。

@h27539 h27539 closed this Feb 1, 2026
@h27539 h27539 reopened this Feb 1, 2026
@Zeyi-Lin Zeyi-Lin self-assigned this Feb 1, 2026
@Zeyi-Lin Zeyi-Lin self-requested a review February 3, 2026 03:50
@Zeyi-Lin Zeyi-Lin merged commit 8b245dd into SwanHubX:main Feb 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants