-
Notifications
You must be signed in to change notification settings - Fork 184
feat: open api unit tests #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- add unit test and fix bugs of getting all projects through OpenApi - add unit tests for OpenApi runs and run.history()
Summary of ChangesHello @Bainianzzz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过为Open API中一些复杂的核心功能添加全面的单元测试来提高代码的健壮性和可靠性。这些测试利用 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 为 OpenApi 中几个较为复杂的功能添加了单元测试,并修复了在测试过程中发现的 projects 分页功能的 bug。整体来看,新添加的测试用例结构清晰,有效地利用了 mock 来模拟依赖,覆盖了 run.history()、实验数据展平、用户权限校验等关键逻辑。
代码审查中,我发现 projects 分页的修复方式虽然解决了 bug,但在内存效率上可以进一步优化,以更好地发挥迭代器的优势。此外,针对分页功能的测试用例也可以通过模拟不同页面的返回数据来增强其健壮性。我也对 history 功能的测试断言提出了一个小的改进建议。
具体的建议请见各文件的审查评论。
Description
给OpenApi中较为复杂的功能加上了单元测试,全部使用magicMock和patch模拟请求,包括: