Skip to content

Comments

feat: sync_wandb and converter add more params#1394

Merged
SAKURA-CAT merged 2 commits intomainfrom
feat/wandb-converter-add-group
Dec 27, 2025
Merged

feat: sync_wandb and converter add more params#1394
SAKURA-CAT merged 2 commits intomainfrom
feat/wandb-converter-add-group

Conversation

@Zeyi-Lin
Copy link
Member

增加了groupjob_type参数

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Zeyi-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily aims to extend SwanLab's capability to synchronize and convert metadata from Weights & Biases (W&B) runs. By incorporating support for key parameters such as group and job_type, SwanLab can now more comprehensively capture and display the organizational structure and type information of W&B experiments. This enhancement improves the user experience for managing and analyzing W&B experiments within the SwanLab platform.

Highlights

  • Enhanced W&B Parameter Syncing: The parse_wandb_logs method in swanlab/converter/wb/wb_converter.py now passes tags, group, and job_type parameters from W&B runs to swanlab.init.
  • Expanded W&B Sync Arguments: The sync_wandb function in swanlab/sync/wandb.py has been updated to extract and pass group and job_type arguments from W&B runs to the swanlab.init call.
  • Refined W&B User Information Mapping: The wandb_user field in the W&B run information dictionary has been corrected to wandb_entity in swanlab/converter/wb/wb_converter.py, aligning with W&B's concept of entities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 在 sync_wandbWandbConverter 中增加了对 groupjob_type 参数的支持,与 wandb 的功能对齐。代码实现基本正确,但在 WandbConverter 中直接访问 wb_run 的新属性可能存在兼容性问题。我提出了一条建议,通过使用 getattr 来增强代码的健壮性,以处理来自旧版本 wandb 或没有这些属性的运行数据。此外,将 wandb_user 更改为 wandb_entity 提高了元数据的一致性,是个不错的改进。

@Zeyi-Lin Zeyi-Lin requested a review from SAKURA-CAT December 26, 2025 07:24
@Zeyi-Lin Zeyi-Lin self-assigned this Dec 26, 2025
@Zeyi-Lin Zeyi-Lin added the 💪 enhancement New feature or request label Dec 26, 2025
@SAKURA-CAT SAKURA-CAT merged commit 54c4604 into main Dec 27, 2025
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the feat/wandb-converter-add-group branch December 27, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants