feat: sync_wandb and converter add more params#1394
Conversation
Summary of ChangesHello @Zeyi-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily aims to extend SwanLab's capability to synchronize and convert metadata from Weights & Biases (W&B) runs. By incorporating support for key parameters such as Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
本次 PR 在 sync_wandb 和 WandbConverter 中增加了对 group 和 job_type 参数的支持,与 wandb 的功能对齐。代码实现基本正确,但在 WandbConverter 中直接访问 wb_run 的新属性可能存在兼容性问题。我提出了一条建议,通过使用 getattr 来增强代码的健壮性,以处理来自旧版本 wandb 或没有这些属性的运行数据。此外,将 wandb_user 更改为 wandb_entity 提高了元数据的一致性,是个不错的改进。
增加了
group、job_type参数