Skip to content

Comments

feat: lightning integration add resume id#1385

Merged
SAKURA-CAT merged 2 commits intomainfrom
feat/lightning-resume
Dec 20, 2025
Merged

feat: lightning integration add resume id#1385
SAKURA-CAT merged 2 commits intomainfrom
feat/lightning-resume

Conversation

@Zeyi-Lin
Copy link
Member

Description

Closes: #1383

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Zeyi-Lin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the PyTorch Lightning integration by adding the capability to resume existing SwanLab runs. By allowing users to provide a specific run ID during logger initialization, it streamlines the process of continuing interrupted or previously started experiments, improving workflow efficiency for machine learning practitioners.

Highlights

  • Run Resumption: Introduced an id parameter to the SwanLabLogger constructor, enabling users to specify an existing run ID for resuming experiments.
  • Configuration Update: Modified the internal SwanLab initialization to explicitly set resume: "allow" and pass the provided id, facilitating the resumption process.
  • Internal State Management: Added self._resume to store the resume setting, ensuring the logger's internal state reflects the resumption capability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to resume runs in the PyTorch Lightning integration by adding an id parameter. The changes are well-implemented, correctly setting resume='allow' and passing the id to swanlab.init. While reviewing, I noticed a minor pre-existing bug in swanlab/integration/pytorch_lightning.py on line 90. There's a typo (decsription instead of description) when retrieving the description, which prevents it from being set correctly. Since you're already working in this file, it would be beneficial to correct this.

@Zeyi-Lin Zeyi-Lin requested a review from SAKURA-CAT December 19, 2025 16:54
@Zeyi-Lin Zeyi-Lin self-assigned this Dec 19, 2025
@SAKURA-CAT SAKURA-CAT merged commit 139377d into main Dec 20, 2025
5 checks passed
@SAKURA-CAT SAKURA-CAT deleted the feat/lightning-resume branch December 20, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pytorch_lightning中使用id报错,会报错You can't pass id when resume=never or resume=False

2 participants