Skip to content

Comments

fix(data): preserve more field in media metrics to fix image loading …#1359

Merged
SAKURA-CAT merged 4 commits intoSwanHubX:mainfrom
Talljack:fix/issue-1354-image-loading
Dec 5, 2025
Merged

fix(data): preserve more field in media metrics to fix image loading …#1359
SAKURA-CAT merged 4 commits intoSwanHubX:mainfrom
Talljack:fix/issue-1354-image-loading

Conversation

@Talljack
Copy link
Contributor

@Talljack Talljack commented Dec 5, 2025

…issue

  • Modified __filter_list to accept keep_none_list parameter
  • Ensure more field is always present in log data even when all values are None
  • This fixes the frontend TypeError when accessing more[0]

Fixes #1354

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please
mention it here.

Closes: #(issue)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue
for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

…issue

- Modified __filter_list to accept keep_none_list parameter
- Ensure more field is always present in log data even when all values are None
- This fixes the frontend TypeError when accessing more[0]

Fixes SwanHubX#1354
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Talljack, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a frontend TypeError related to image loading by modifying how media metrics data, specifically the more field, is processed. The core change involves enhancing a list filtering utility to ensure that certain lists, like the more field, always maintain their list structure, even when empty or containing only None values. This prevents the frontend from encountering errors when expecting a list and receiving None instead.

Highlights

  • Modified __filter_list method: The __filter_list static method in swanlab/data/modules/wrapper.py has been updated to accept a new boolean parameter, keep_none_list.
  • Preservation of more field structure: The more field, which contains media metrics, will now always retain its list structure, even if all its internal values are None. This is achieved by passing keep_none_list=True to the modified __filter_list method when processing the more data.
  • Frontend TypeError fix: This change directly addresses a TypeError that occurred on the frontend when attempting to access more[0], which previously failed if more was filtered out entirely when all its elements were None.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves a frontend TypeError by modifying __filter_list to conditionally preserve lists containing only None values. The logic is sound. My review includes suggestions to improve the clarity of a docstring and to make the implementation of __filter_list more concise.

SAKURA-CAT and others added 3 commits December 5, 2025 17:36
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Updated the __filter_list static method to return None only when the input list is empty or all elements are None, unless keep_none_list is True. This refactoring simplifies the logic and improves code readability.
@SAKURA-CAT
Copy link
Member

虽然这会导致前端出现一堆空对象:
image

不过总的来讲问题不大~

@SAKURA-CAT SAKURA-CAT added the 🐛 bug Something isn't working label Dec 5, 2025
@SAKURA-CAT SAKURA-CAT merged commit 1a89607 into SwanHubX:main Dec 5, 2025
5 checks passed
@Talljack Talljack deleted the fix/issue-1354-image-loading branch December 5, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

本地使用图片加载不出来

2 participants