Skip to content

fix(core): add default timeout for request session #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SAKURA-CAT merged 2 commits into from
Dec 5, 2025
Merged

fix(core): add default timeout for request session #1358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b8abc9
fix(core): add default timeout for request session
swpfY Dec 5, 2025
79ecb09
optmize swanlab/core_python/session.py
swpfY Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion swanlab/core_python/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,24 @@

from swanlab.package import get_package_version

# 设置默认超时时间为 60s
DEFAULT_TIMEOUT = 60


# 创建一个自定义的 HTTPAdapter，用于注入默认超时
class TimeoutHTTPAdapter(HTTPAdapter):
def __init__(self, *args, **kwargs):
# 从 kwargs 中取出默认超时时间，如果没有则设为 None
self.timeout = kwargs.pop("timeout", None)
super().__init__(*args, **kwargs)

def send(self, request, **kwargs):
# 如果 kwargs 中没有显式设置 timeout，则使用 self.timeout
if "timeout" not in kwargs and self.timeout is not None:
kwargs["timeout"] = self.timeout

return super().send(request, **kwargs)


def create_session() -> requests.Session:
"""
Expand All @@ -24,7 +42,7 @@ def create_session() -> requests.Session:
status_forcelist=[429, 500, 502, 503, 504],
allowed_methods=frozenset(["GET", "POST", "PUT", "DELETE", "PATCH"]),
)
adapter = HTTPAdapter(max_retries=retry)
adapter = TimeoutHTTPAdapter(max_retries=retry, timeout=DEFAULT_TIMEOUT)
session.mount("https://", adapter)
session.mount("http://", adapter)
session.headers["swanlab-sdk"] = get_package_version()
Expand Down