Merged
Conversation
Added unit tests for the trace_metrics function in test_upload.py, covering batching, pending state, and status code handling. Also updated the __all__ list in upload.py to include trace_metrics and MetricDict for proper module exports.
Zeyi-Lin
approved these changes
Nov 9, 2025
Introduced a 1-second delay between batches when uploading metrics in trace_metrics to avoid potential server overload. Also updated DataPorter to remove unused LogModel import and changed _filter_log_by_epoch return type to bool.
Introduced timing checks in the test for batch metric uploads to ensure the process takes longer than 3 seconds, improving test coverage for upload duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加了一些测试样例