Feature/improve refactored global search performance #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation for reducing re-renders. Each "SourceSearchPreview" component would re-render at each key press.
Only re-render in case the "searchString" (or other props) changed. Due to the query the components rendered everytime a key was pressed in the search field
Do not wait for the debounced "searchString" in case it will be an empty string anyways
In case many sources are being searched, the outdated requests can block the new ones. To prevent this, the old ones will get canceled.
In case multiple search requests are finished in short succession, each state update would trigger an update. By debouncing these updates, the search results do not "jump around" as much, since the sources get sorted by search request state and result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.