Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add translation keys #246

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Feature/add translation keys #246

merged 4 commits into from
Mar 23, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Feb 19, 2023

No description provided.

src/components/SourceCard.tsx Outdated Show resolved Hide resolved
src/components/library/LibraryMangaGrid.tsx Outdated Show resolved Hide resolved
src/components/library/LibraryOptionsPanel.tsx Outdated Show resolved Hide resolved
src/i18n/locale/en.json Outdated Show resolved Hide resolved
@schroda schroda changed the title [WIP] Feature/add translation keys Feature/add translation keys Mar 6, 2023
@schroda schroda marked this pull request as ready for review March 6, 2023 01:49
schroda added 4 commits March 11, 2023 19:55
"t" can return null by default.
This was already disabled in the config, but it had no effect on tsc.
key was missing and since this is a constant the translation wouldn't update in case the language got changed after first load.
@AriaMoradi AriaMoradi merged commit d58bd6c into Suwayomi:master Mar 23, 2023
@schroda schroda deleted the feature/add_translation_keys branch April 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants