Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Save reader settings per manga #213

Closed
schroda opened this issue Jan 1, 2023 · 0 comments · Fixed by #216
Closed

[Feature Request] Save reader settings per manga #213

schroda opened this issue Jan 1, 2023 · 0 comments · Fixed by #216
Labels
enhancement New feature or request

Comments

@schroda
Copy link
Collaborator

schroda commented Jan 1, 2023

What feature should be added to Tachidesk?

Each manga should have their own reader settings instead of using the same reader settings for every manga.

Why/Project's Benefit/Existing Problem

Currently there are only global reader settings.
By having custom reader settings for each manga you don't have to update the settings each time you switch to a different manga that you want to read with different reader settings.

E.g.:
Switching from a webtoon to a manga. (webtoon: Reader Type = Webtoon; manga: Reader Type = Duoble Page (LTR)

@schroda schroda added the enhancement New feature or request label Jan 1, 2023
AriaMoradi pushed a commit that referenced this issue Jan 6, 2023
* [#213] Add missing "meta" property

- IManga
- IMangaCard (optional)
- IChapter
- ICategory

* [#213] Add util functions for handling metadata

- global server
- manga
- chapter
- category

* [#213] Use "ReaderSettings" from the manga metadata

- get ReaderSettings from manga metadata
- remove unnecessary check "make sure settings has all the keys"
    in case the stored settings in the metadata are outdated they will be filled with default values

* [#213] Reload manga only in case "mangaId" changed

In case the chapter is still from the same manga, a reload is unnecessary

* [#213] Only update the changed reader setting

Otherwise the app has to send patch requests to the server for every setting even if it didn't change

* [#213] Hide "openButton" on first render in case "navBar" is shown

The "openButton" was always set to be visible event in case the navBar was shown on the first render

* [#213] Open the "ReaderNavBar" if needed after receiving new settings

Otherwise, the drawer won't open in case the "navBar" was hidden on the first render since the default state in that case was set to false

* [#213] Update "ReaderSettings" after receiving the manga response

Otherwise, the default settings aren't getting removed

* [#213] Hide/Show "OpenButton" when opening/closing the drawer

Otherwise, the button stays hidden until it gets updated due to scrolling

* [#213] Keep "ReaderNavBar" state when opening prev/next chapter

In case the navBar wasn't sticky but opened, it got closed when the prev/next chapter got opened

* [#213] Prevent "ReaderNavBar" from closing when changing "staticNav" setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant