Prevent greater last page read than page count #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about chapters where we haven't fetched the pages so the pagecount is -1? |
In case multiple chapters are getting updated, the last page read might be higher than the available pages of a chapter
schroda
force-pushed
the
fix/gql_chapters_mutation_prevent_greater_last_page_read_than_page_count
branch
from
c317ce3 to
c1ef6c9
Compare
it would have broken coerceIn... |
Syer10
approved these changes
Apr 28, 2024
schroda
deleted the
fix/gql_chapters_mutation_prevent_greater_last_page_read_than_page_count
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case multiple chapters are getting updated, the last page read might be higher than the available pages of a chapter