Make sure to always send finished chapter downloads with the download status #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schroda
force-pushed
the
fix/gql_download_subscription_is_missing_finished_chapter_donwlaods
branch
from
f62a7bc to
c2e5e25
Compare
schroda
force-pushed
the
fix/gql_download_subscription_is_missing_finished_chapter_donwlaods
branch
from
c2e5e25 to
492fe54
Compare
… status Due to not immediately sending the status, the finished chapters were already removed from the queue by the time the status was actually send to the client. This caused the client to never receive a status with the chapters downloaded flag to be true, resulting in the client to not know that a chapter is downloaded
schroda
force-pushed
the
fix/gql_download_subscription_is_missing_finished_chapter_donwlaods
branch
from
492fe54 to
6b702a2
Compare
Syer10
approved these changes
Dec 9, 2023
schroda
deleted the
fix/gql_download_subscription_is_missing_finished_chapter_donwlaods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to not immediately sending the status, the finished chapters were already removed from the queue by the time the status was actually send to the client. This caused the client to never receive a status with the chapters downloaded flag to be true, resulting in the client to not know that a chapter is downloaded