Do not reset already loaded config when updating config file #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the user config file has to be updated, the file needs to get reset. While doing the reset, the already loaded internal state of the config got also reset, but was never updated again. Due to this, the internal state of the config was the default config reference until the next server startup Regression introduced with a314465.
Syer10
approved these changes
Sep 6, 2023
schroda
deleted the
fix/updating_outdated_user_config_causes_default_values_to_be_used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the user config file has to be updated, the file needs to get reset. While doing the reset, the already loaded internal state of the config got also reset, but was never updated again. Due to this, the internal state of the config was the default config reference until the next server startup
Regression introduced with a314465.