Fix/downloader manager persisting queue #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syer10
requested changes
Aug 6, 2023
Comment on lines
155
to
138
| saveQueueFlow.flatMapLatest { | ||
| saveQueue.acquire() | ||
| flow { emit(it) } | ||
| }.onEach { | ||
| mutex.withLock { | ||
| saveDownloadQueue() | ||
| saveQueue.release() | ||
| } | ||
| }.launchIn(scope) | ||
| } |
There was a problem hiding this comment.
I'm pretty sure this can just be replaced by using
val saveQueueFlow = MutableSharedFlow(extraBufferCapacity = 1, onBufferOverflow = BufferOverflow.DROP_OLDEST)
instead of this magic
There was a problem hiding this comment.
but everyone needs a little magic in their lives - updated
schroda
force-pushed
the
fix/downloader_manager_persisting_queue
branch
from
93dcd31 to
55d6ec5
Compare
The download queue was never saved after a download was finished. This caused finished download to be restored on a server start, which caused unnecessary "downloads" which most of the time would just finish immediately since the pages were still in the cache
Since multiple downloaders could be finished at the same time, the download queue should be saved synchronously
This gets called everytime a downloader finished downloading all chapters of its source. Since the queue is now saved everytime a download is finished, this is trigger is not needed anymore
schroda
force-pushed
the
fix/downloader_manager_persisting_queue
branch
from
55d6ec5 to
9e2428a
Compare
Syer10
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is rebased onto #638