Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/updater automated update max interval of 23 hours #606

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Jul 21, 2023

is rebased onto #605

@schroda schroda force-pushed the fix/updater_automated_update_max_interval_of_23_hours branch from bffb9b0 to 9e99ccd Compare July 21, 2023 17:21
@Syer10
Copy link
Collaborator

Syer10 commented Jul 21, 2023

Needs to be rebased/merged with master

schroda added 4 commits July 22, 2023 10:54
It's not possible to schedule a task via cron expression to run every x hours in case the set hours are greater than 23.
To be able to do this and still keep the functionality provided by the "HAScheduler" it has to also support repeated tasks scheduled via the default Timer
@schroda schroda force-pushed the fix/updater_automated_update_max_interval_of_23_hours branch from 9e99ccd to f024a06 Compare July 22, 2023 08:54
@schroda
Copy link
Collaborator Author

schroda commented Jul 22, 2023

rebased onto master

Gets rid of an unnecessary setting
@Syer10 Syer10 merged commit c02496c into Suwayomi:master Jul 22, 2023
@schroda schroda deleted the fix/updater_automated_update_max_interval_of_23_hours branch July 22, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants