Add logic to only update specific categories #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syer10
requested changes
Mar 12, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/controller/UpdateController.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
2 times, most recently
from
0594d3d to
c70c1a9
Compare
Syer10
reviewed
Mar 13, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/controller/UpdateController.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
from
c70c1a9 to
682975a
Compare
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
from
682975a to
6afa94b
Compare
Syer10
requested changes
Mar 23, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/controller/UpdateController.kt
Outdated
Show resolved
Hide resolved
| /* | ||
| * Copyright (C) Contributors to the Suwayomi project | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| enum class IncludeInUpdate(@JsonValue val value: Int) { | ||
| EXCLUDE(0), INCLUDE(1), UNSET(2); |
There was a problem hiding this comment.
Why is UNSET 2 and not 0? I image 0 as a sane default
There was a problem hiding this comment.
no real reason, I just went with boolean (0 = false/exclude, 1 = true/include) which left 2 for UNSET
There was a problem hiding this comment.
well if we are mapping to numbers, -1 would be better for UNSET as it's not a natural number.
There was a problem hiding this comment.
But all things considered, as this is not c/c++ it doesn't matter which number we are mapping to.
There was a problem hiding this comment.
I also thought about -1, I prefer that over having UNSET as 0
There was a problem hiding this comment.
I changed it to -1
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/CategoryManga.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
2 times, most recently
from
c557c45 to
2b6a751
Compare
|
Fix merge conflicts |
AriaMoradi
reviewed
Mar 25, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/controller/UpdateController.kt
Outdated
Show resolved
Hide resolved
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
2 times, most recently
from
9e146bc to
120a7f1
Compare
Syer10
approved these changes
Mar 25, 2023
|
Fix merge conflicts |
Makes it possible to only update specific categories. In case a manga is in an excluded category it will be excluded even if it is also in an included category.
schroda
force-pushed
the
feature/global_update_only_update_specific_categories
branch
from
120a7f1 to
0b8df4b
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to only update specific categories.
In case a manga is in an excluded category it will be excluded even if it is also in an included category.