Fixes Page index issues for some providers #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Syer10 any ideas for a faster/better approach? |
|
This looks fine to me, since it does the ordering and offet using a sql query it should be fast |
|
Though I took a look at Tachiyomi and it seems like Tachiyomi re-indexes the pages anyway before downloading them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Page starting index issues for certain providers.
Background
Tachiyomi does not standardize the starting indexes for it's extensions. This has led to some extensions starting the Page indexs from 0 and others from 1. This causes the reader in Tachidesk to crash since the first api to get Page with index 0 fails