Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add category and global meta #438

Merged
merged 1 commit into from
Nov 7, 2022
Merged

add category and global meta #438

merged 1 commit into from
Nov 7, 2022

Conversation

AriaMoradi
Copy link
Member

@AriaMoradi AriaMoradi commented Nov 7, 2022

closes #312

@AriaMoradi AriaMoradi requested a review from Syer10 November 7, 2022 11:34
}
},
behaviorOf = { ctx, key, value ->
GlobalMeta.modifyMeta(key, value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to be able to edit multiple keys in one request?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a future PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it may be added in future, it might be good idea to make it future-proof now. As it is proposed would make it breaking change when changed later.

Also I have noticed that some places in API use JSON body and some places use fromParams. Is there any system in which uses which? I find JSON more practical, since we don't use html forms anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it may be added in future, it might be good idea to make it future-proof now. As it is proposed would make it breaking change when changed later.

It's fine as long as we haven't made a stable release.

Also I have noticed that some places in API use JSON body and some places use fromParams. Is there any system in which uses which? I find JSON more practical, since we don't use html forms anywhere.

I prefer pathParam and formParam while the request expects a few keys, when it takes a lot of or long parameters I use JSON.

@AriaMoradi AriaMoradi merged commit e850049 into master Nov 7, 2022
@AriaMoradi AriaMoradi deleted the global-category-meta branch November 7, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Meta key to store data on server level
2 participants