New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(alerts and reports modal): Create demo version of modal layout #13

Closed

rtexelm wants to merge 2 commits into master from refactor/alerts-reports/modal/redesign/76184

Collaborator

rtexelm commented Nov 21, 2023

SUMMARY

Redesign the layout of reports and alerts modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API


          Create demo version of modal layout

8a5ebe4

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.


          Style headers, add margin const, tidy

45a3436

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
26 Code Smells

No Coverage information
64.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

rtexelm closed this

rtexelm deleted the refactor/alerts-reports/modal/redesign/76184 branch

February 23, 2024 02:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet