Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot] Run grit migration: Apply a GritQL pattern #12

Closed
wants to merge 3 commits into from

Conversation

grit-app[bot]
Copy link

@grit-app grit-app bot commented Nov 3, 2023

⚠️ This migration is out of date with the main branch. Update with Grit ⚠️

⚠️ This pull request was auto-generated with Grit. ⚠️

This pull request was created with these settings:

  • Target branch: master
  • Source files: Expandable.tsx, ChartFrame.tsx, TooltipTable.tsx, TooltipFrame.tsx, Histogram.jsx
  • Preset pattern: react_to_hooks – This pattern converts React class components to functional components, with hooks.
Pattern body
engine marzano(0.1)
language js

// Most of the logic for this pattern is in react_hooks.grit
// https://github.com/getgrit/js/blob/main/.grit/patterns/react_hooks.grit

pattern regular_first_step() {
  $use_ref_from = .,
  $handler_callback_suffix = "Handler",
  first_step($use_ref_from, $handler_callback_suffix)
}

sequential {
    file(body = program(statements = some bubble($program) regular_first_step())),
    // Run it 3 times to converge
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file(body = second_step(handler_callback_suffix = "Handler")),
    file($body) where {
      $body <: program($statements),
      $statements <: bubble($body, $program) and {
        maybe adjust_imports(),
        add_more_imports(),
      }
    }
}

Please feel free to provide feedback on this pull request. Any comments will be incorporated into future migrations.

@grit-app grit-app bot force-pushed the grit/6c7b5b87-18ca-4bbf-b0a1-6f067698a053 branch from 5548a60 to c75b3bc Compare November 5, 2023 16:57
Copy link
Author

grit-app bot commented Nov 5, 2023

Updated pull request with a migration run from base commit 515452c. View run

I have backed up the previous version of this pull request on branch grit-backup/6de6c820-5c6d-4fad-9fd3-5f9ef85dcbcf.

@grit-app grit-app bot force-pushed the grit/6c7b5b87-18ca-4bbf-b0a1-6f067698a053 branch from c75b3bc to 3211c8d Compare November 5, 2023 21:08
Copy link
Author

grit-app bot commented Nov 5, 2023

Updated pull request with a migration run from base commit 515452c. View run

I have backed up the previous version of this pull request on branch grit-backup/33285394-2bab-4c58-bf78-375339c59154.

@eschutho eschutho self-requested a review as a code owner November 16, 2023 01:11
Copy link
Author

grit-app bot commented Nov 16, 2023

❌ I was unable to rebase this pull request because it contains the following commit which failed to merge cleanly and was not created by me: fb42078. Please resolve manually and try again.

Copy link

sonarcloud bot commented Nov 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 23 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 252 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@eschutho eschutho closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant