Skip to content

Commit

Permalink
chore: adding 'no-experimental-fetch' node option by default (apache#…
Browse files Browse the repository at this point in the history
  • Loading branch information
rusackas authored Dec 12, 2023
1 parent 3a6fe9f commit 46e6778
Show file tree
Hide file tree
Showing 3 changed files with 92 additions and 76 deletions.
14 changes: 1 addition & 13 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -643,18 +643,6 @@ There are three types of assets you can build:
2. `npm run dev-server`: local development assets, with sourcemaps and hot refresh support
3. `npm run build-instrumented`: instrumented application code for collecting code coverage from Cypress tests

If this type of error comes while building assets(i.e using above commands):

```bash
Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize
```

Then put this:

```bash
export NODE_OPTIONS=--no-experimental-fetch
```

If while using the above commands you encounter an error related to the limit of file watchers:

```bash
Expand All @@ -663,7 +651,6 @@ Error: ENOSPC: System limit for number of file watchers reached
The error is thrown because the number of files monitored by the system has reached the limit.
You can address this this error by increasing the number of inotify watchers.


The current value of max watches can be checked with:
```bash
cat /proc/sys/fs/inotify/max_user_watches
Expand All @@ -680,6 +667,7 @@ To confirm that the change succeeded, run the following command to load the upda
```bash
sudo sysctl -p
```

#### Webpack dev server

The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`.
Expand Down
153 changes: 90 additions & 63 deletions superset-frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions superset-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@
"react-test-renderer": "^16.9.0",
"redux-mock-store": "^1.5.4",
"sinon": "^9.0.2",
"source-map": "^0.7.4",
"source-map-support": "^0.5.21",
"speed-measure-webpack-plugin": "^1.5.0",
"storybook-addon-jsx": "^7.3.14",
Expand Down

0 comments on commit 46e6778

Please sign in to comment.