Skip to content

Conversation

@TomerAberbach
Copy link
Contributor

globby allows passing readonly string[] and when switching to tinyglobby I noticed I couldn't, so here's a PR to fix that (plus allow all options to be readonly as well).

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 1, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tinyglobby@153

commit: 894c2c4

Copy link
Owner

@SuperchupuDev SuperchupuDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the pr and nice catch! can you update globSync too?

@TomerAberbach
Copy link
Contributor Author

@SuperchupuDev just an FYI that it seems like neither format nor lint:fix solve the CI failure (not sure why)

For now I manually resolved the import ordering problem

@SuperchupuDev
Copy link
Owner

yeah it's a biome quirk since import sorting technically isn't linting 😅 will change it into a check:fix script which does take it into account 👍

Copy link
Owner

@SuperchupuDev SuperchupuDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! wow typescript is odd sometimes 😅

@SuperchupuDev SuperchupuDev merged commit 94c0692 into SuperchupuDev:main Aug 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants