Update "template" copy to "example" [Fixes #254] #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
force-pushed
the
templates-to-examples
branch
from
260c640
to
57d09ad
Compare
javier-tarazaga
suggested changes
Jun 10, 2020
| @@ -44,13 +44,13 @@ class NewProjectDialog extends Component<IProps> { | |||
| <div className={classNames([style.menu, 'contextMenu'])}> | |||
| <ul> | |||
| <li> | |||
| <div onClick={() => createProjectFromTemplate(Templates.templates[3])}> | |||
| Create empty project | |||
| <div onClick={this.startWithTemplate}> | |||
There was a problem hiding this comment.
I would make sure we sync the terminology. If we call them examples in the ui, then I think would be best to rename them internally as well.
|
@samajammin ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Rename project "templates" to "examples".
Alternate Designs
See #254 for discussion.
Benefits
See #254 for discussion.
Possible Drawbacks
Potential for confusion from returning visitors but most visitors are new.
Verification Process
Ran project locally
Github Issues
#254