S-Expression: Minimize lag when parsing level names #3103
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sexp::Parser` now supports specifying a custom `depth` property for omitting (not parsing) structures deeper than `depth` in the tree, starting from 0. This optimizes parsing level names from level files a ton, since level files tend to be very big and used to take a while to parse collectively.
|
Unrelated, but i love you Vankata, thanks for delivering on my complaints! :-) I recommend thorough testing on this of course, even in this codebase. Its good to ensure this can't be broken in any means. |
Frostwithasideofsalt
approved these changes
Nov 17, 2024
Try loading the levels of "The Crystal Catacombs" in the editor. |
|
I tested this somewhat in the editor and stuff...Seems to work. |
What I mean to say is, I encourage unit testing on this, maybe with only "broken" levels, to ensure segfaults or other nonsense won't happen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sexp::Parsernow supports specifying a customdepthproperty for omitting (not parsing) structures deeper thandepthin the tree, starting from 0. This optimizes parsing level names from level files a ton, since level files tend to be very big and used to take a while to parse collectively.