Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling and comment consistency in the source code. #2545

Merged
merged 23 commits into from
Aug 12, 2023
Merged

Fix spelling and comment consistency in the source code. #2545

merged 23 commits into from
Aug 12, 2023

Conversation

bruhmoent
Copy link
Member

This PR aims to improve the readability, spelling, and consistency of the comments in the source code. If you have noticed any easy-to-spot mistakes, please create a PR in my branch to quickly resolve it and if more mistakes are apparent in a file, only write down the file name and I will track the issues.

@bruhmoent bruhmoent marked this pull request as draft July 17, 2023 15:07
@mrkubax10 mrkubax10 added status:in-progress Progress has been done, but more is intended be done category:code labels Jul 19, 2023
@bruhmoent bruhmoent marked this pull request as ready for review July 19, 2023 11:05
@bruhmoent
Copy link
Member Author

Please take a deeper look before merging.

@mrkubax10 mrkubax10 added status:needs-review Work needs to be reviewed by other people and removed status:in-progress Progress has been done, but more is intended be done labels Jul 19, 2023
@mrkubax10
Copy link
Member

Could you fix merge conflicts?

@bruhmoent bruhmoent requested a review from mrkubax10 July 21, 2023 18:54
src/addon/downloader.cpp Outdated Show resolved Hide resolved
src/badguy/angrystone.cpp Outdated Show resolved Hide resolved
src/badguy/angrystone.cpp Outdated Show resolved Hide resolved
src/badguy/badguy.cpp Outdated Show resolved Hide resolved
src/badguy/goldbomb.cpp Outdated Show resolved Hide resolved
src/supertux/menu/editor_levelset_select_menu.cpp Outdated Show resolved Hide resolved
src/supertux/menu/editor_sectors_menu.cpp Outdated Show resolved Hide resolved
src/util/file_system.cpp Outdated Show resolved Hide resolved
src/video/gl/gl_painter.cpp Outdated Show resolved Hide resolved
src/video/gl/gl_video_system.cpp Outdated Show resolved Hide resolved
@mrkubax10
Copy link
Member

Could you fix merge conflicts (second time)?

@mrkubax10 mrkubax10 closed this Aug 2, 2023
@mrkubax10 mrkubax10 reopened this Aug 2, 2023
src/addon/addon_manager.cpp Outdated Show resolved Hide resolved
src/video/gl/gl_video_system.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Vankata453 Vankata453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, additionally, information regarding comment style could be added to CODINGSTYLE.md.

@mrkubax10 mrkubax10 merged commit 5f5d018 into SuperTux:master Aug 12, 2023
29 of 36 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants