-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update several icons + update missing texture #2493
Conversation
In case anyone wants to code in an alt. version of the coin counter for the Revenge In Redmond Add-On.
[ci skip]
[ci skip]
* Adjust icon positions * Positioning
Final things to be done:
@MatusGuy Since you have write access to this branch, feel free to commit directly to it! |
epic ci skip fail |
I'm not so sure about the invisible wall one. Doesn't really convey its meaning... |
If that one does not so does the invisible bonus block either, as it is using the same design choice. |
Well, that one was a bad design choice as well, IMO. |
How else to make an icon for something "invisible" then? |
You don't. |
Too bad. I'm gonna keep it then |
How about this: Keep the transparency but have a brick wall as an icon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code-wise.
We should just not add an icon (its invisible). i say it conveys its meaning + it reduces filesize |
This is neither adds nor changes anything. That would be the same thing. Imo. that would even look "cheap" as it's just an image with reduced opacity. |
This reverts commit ca717c8.
And this time I put them into the right folder... [ci skip]
Regarding invisible wall, the proposed icon uses that big block which people use as a wall in levels, right? And with the usual transparency squares, it seems fairly well explained what it does. The only downside imo is that you might need to strain your eyes a bit to understand what exactly that is. I probably would cut it in half (bottom half opaque and upper half semi-transparent like current one, with a red line in between) and/or consider using red brick tiles, but that's more of an accessibility thing than anything else. I believe there might be worse stuff in the game, at least in terms of "strain the eye to see" than this icon. |
Honestly, I believe the texture is fine. If the user is not exactly sure what it is for, they can hover over it and the object name will be shown. |
bruh! |
oopsies!
List of changes:
TODO: