Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several icons + update missing texture #2493

Merged
merged 33 commits into from
Sep 11, 2023
Merged

Update several icons + update missing texture #2493

merged 33 commits into from
Sep 11, 2023

Conversation

Rusty-Box
Copy link
Member

@Rusty-Box Rusty-Box commented Jun 12, 2023

List of changes:

  • Update player hud icons (includes coin counter and level timer)
  • Make missing texture easier on the eyes

TODO:

  • Several level editor icons (Background object, Spawnpoint, Decal etc.)
  • Improve "level stats" icons
  • A few code adjustments regarding the HUD and states shown during the PAUSE menu

@Rusty-Box Rusty-Box added involves:editor status:in-progress Progress has been done, but more is intended be done category:design labels Jun 12, 2023
@Rusty-Box
Copy link
Member Author

Rusty-Box commented Sep 4, 2023

Final things to be done:

  • Adjust the powerup HUD counter, so it does not stick into the new coin counter
  • Fix Timer HUD icon to not be affected by ambient light (i think someone mentioned it was due to the timer not being drawn properly in the game's code)

@MatusGuy Since you have write access to this branch, feel free to commit directly to it!

@Rusty-Box Rusty-Box marked this pull request as ready for review September 4, 2023 22:30
@Rusty-Box Rusty-Box added status:needs-review Work needs to be reviewed by other people and removed status:in-progress Progress has been done, but more is intended be done labels Sep 4, 2023
@MatusGuy
Copy link
Member

MatusGuy commented Sep 5, 2023

epic ci skip fail

@tobbi
Copy link
Member

tobbi commented Sep 5, 2023

I'm not so sure about the invisible wall one. Doesn't really convey its meaning...

@Rusty-Box
Copy link
Member Author

I'm not so sure about the invisible wall one. Doesn't really convey its meaning...

If that one does not so does the invisible bonus block either, as it is using the same design choice.

@tobbi
Copy link
Member

tobbi commented Sep 5, 2023

I'm not so sure about the invisible wall one. Doesn't really convey its meaning...

If that one does not so does the invisible bonus block either, as it is using the same design choice.

Well, that one was a bad design choice as well, IMO.

@Rusty-Box
Copy link
Member Author

How else to make an icon for something "invisible" then?

@tobbi
Copy link
Member

tobbi commented Sep 5, 2023

How else to make an icon for something "invisible" then?

You don't.

@Rusty-Box
Copy link
Member Author

Too bad. I'm gonna keep it then

@tobbi
Copy link
Member

tobbi commented Sep 5, 2023

How about this: Keep the transparency but have a brick wall as an icon?

Copy link
Member

@mrkubax10 mrkubax10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise.

@MatusGuy
Copy link
Member

MatusGuy commented Sep 5, 2023

Too bad. I'm gonna keep it then

We should just not add an icon (its invisible).

i say it conveys its meaning + it reduces filesize

@Rusty-Box
Copy link
Member Author

How about this: Keep the transparency but have a brick wall as an icon?

This is neither adds nor changes anything. That would be the same thing. Imo. that would even look "cheap" as it's just an image with reduced opacity.

src/object/level_time.cpp Outdated Show resolved Hide resolved
src/supertux/statistics.cpp Outdated Show resolved Hide resolved
src/supertux/statistics.cpp Outdated Show resolved Hide resolved
@pazkero
Copy link
Contributor

pazkero commented Sep 6, 2023

Regarding invisible wall, the proposed icon uses that big block which people use as a wall in levels, right? And with the usual transparency squares, it seems fairly well explained what it does.

The only downside imo is that you might need to strain your eyes a bit to understand what exactly that is. I probably would cut it in half (bottom half opaque and upper half semi-transparent like current one, with a red line in between) and/or consider using red brick tiles, but that's more of an accessibility thing than anything else.

I believe there might be worse stuff in the game, at least in terms of "strain the eye to see" than this icon.

big block invisible wall

@Vankata453
Copy link
Member

Honestly, I believe the texture is fine. If the user is not exactly sure what it is for, they can hover over it and the object name will be shown.

@MatusGuy
Copy link
Member

MatusGuy commented Sep 8, 2023

bruh!

@Vankata453 Vankata453 merged commit 95f1417 into SuperTux:master Sep 11, 2023
28 of 33 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants