-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: diff source with destination on conflict #117
feat: diff source with destination on conflict #117
Conversation
Also silences warnings when source and destination don't really conflict.
Looking good! Only need to make the function public so it compiles. Also, I would remove the |
One more comment, it makes sense to me to do the diff the other way around. Say someone added a line to the template and you're displaying that you are skipping because of the line, I would expect that line to be green. Right now however it shows the difference that it will apply if a force is requested which kinda makes sense too. Which one do you think is better? In any case, we should print something like
|
Because I can't stage :)
Whoops missed staging that!
That makes sense to me. I'll update the behavior |
996c681
to
bd57602
Compare
I've updated it to
|
Thanks for the contribution! |
Thanks for accepting! |
Fixes #91
Summary
on false conflict errors.