-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Verify plugin structure #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit completes the structural transformation of the SuperClaude Framework to align with the official Claude Code plugin system. This addresses Issue SuperClaude-Org#419 and implements the detailed migration plan provided in the comprehensive design documents. Key changes include: - Created the full plugin directory structure, including `.claude-plugin/`, `commands/sc/`, `agents/`, `hooks/`, `scripts/`, `docs/`, and `memory/`. - Created and populated all JSON configuration files (`plugin.json`, `.mcp.json`, `hooks/hooks.json`, `marketplace.json`) according to the final design specifications. - Systematically created, renamed, deleted, and reformatted all 25 command and 15 agent markdown files with their complete English content, placing them in the correct directories. - Added utility scripts for migration, validation, and session management. - Updated and created all necessary documentation, including `README.md`, `MIGRATION.md`, and `COMMANDS.md`. - Corrected all inconsistencies from previous reviews, including standardizing the plugin name to 'superclaude' and resolving documentation conflicts. - Implemented a file-structure-based integration test to validate the final plugin structure.
This commit resolves the merge conflict in `README.md` and removes the deleted files that were causing conflicts.
This commit introduces the MCP Recommendation System feature. Key changes include: - Added a `recommendedMcpServers` section to `marketplace.json` to define recommended external MCP servers like `ollama-mcp`. - Created the new `/sc:mcp-setup` command to guide users through the installation of recommended MCP servers. - Created detailed documentation for the new feature in `docs/Reference/mcp-setup.md`. - Updated `README.md` to include a section on the new feature. - Changed the format of `.mcp.json` to reference the marketplace for server recommendations. - Corrected version inconsistencies across `pyproject.toml`, `package.json`, and `VERSION` files, unifying them to `5.0.0`. - Cleaned up documentation by removing out-of-scope files and filling in placeholders. - Ensured all integration tests pass with the new changes.
This commit refactors the MCP server configuration to support a hybrid approach, as requested by the user. Key changes: - Modified `.mcp.json` to define standardized, marketplace-available servers (like `serena` and `context7`) using a `source` reference, while keeping project-specific servers (like `morphllm-fast-apply`) embedded with their direct `npx` commands. - Removed the now-redundant "MCP Recommendation System" feature, including the `/sc:mcp-setup` command and its associated documentation. - Cleaned up `marketplace.json` by removing the `recommendedMcpServers` section. - Updated the `README.md` to remove references to the deleted setup command. This change aligns the project with the user's preferred workflow of using `npx claude-code-templates` for standard servers while maintaining direct control over custom ones. All associated tests have been updated and are passing.
This commit is the result of a verification task. No code changes were made. The investigation confirmed the following: - The repository's file structure aligns with the official Claude Code v4 plugin system. - No legacy configuration files from v3 that could cause conflicts were found within the repository. - Integration tests for the plugin file structure pass successfully.
`Docs/User-Guide-jp/modes.md` ファイル内の手動モード制御の オーバーライド例において、コマンド `/sc:fix auth-issue --introspect` が 欠落していた問題を修正します。 日本語のコメントがコマンドを置き換えてしまっていたため、 ドキュメントの例が不完全になっていました。この変更により、 コマンドとコメントが正しく併記され、ドキュ'メントの 分かりやすさが向上します。
`Docs/User-Guide-jp/modes.md` ファイル内において、日本語コメントがコマンド例を置き換えてしまっていた問題を2箇所修正しました。 この修正にあたり、当初の指摘に加え、他の同様の問題がリポジトリ内に存在しないことを確認するため、`grep`よりも厳密なPythonスクリプトを作成・実行しました。このスクリプトは、全マークダウンファイル内の ` ```shell `ブロックを解析し、コマンドが先行しない日本語コメントを検出するものです。 その網羅的な調査の結果、修正が必要なのは当該ファイルの2箇所のみであり、他には同様の問題が存在しないことを確認済みです。このコミットは、その完全な調査結果を反映したものです。
This commit is the result of an investigation task. No code changes were made. The investigation was conducted to address two user concerns: 1. The reason behind a large number of markdown files being deleted. 2. The existence of any unintentionally commented-out slash commands (`# /...`). Findings: 1. **Deleted Markdown Files:** The mass deletion of files was an intentional part of the project's migration from a v3 architecture to the v4 Claude Code official plugin system, as documented in the README.md. The repository structure is consistent with the new v4 architecture. 2. **Commented-out Commands:** A thorough search was conducted across the entire repository for the `# /` pattern. All detected instances were found to be either placeholders for documentation purposes (e.g., `# /sc:command-name`) or markdown headings, not accidentally disabled commands. Conclusion: The repository is in a clean and intentional state. The file deletions were part of a planned migration, and there are no inadvertently commented-out commands.
This commit is the result of an investigation task. No code changes were made. The investigation was conducted to address two user concerns: 1. The reason behind a large number of markdown files being deleted. 2. The existence of any unintentionally commented-out slash commands (`# /...`). Findings: 1. **Deleted Markdown Files:** The mass deletion of files was an intentional part of the project's migration from a v3 architecture to the v4 Claude Code official plugin system, as documented in the README.md. The repository structure is consistent with the new v4 architecture. 2. **Commented-out Commands:** A thorough search was conducted across the entire repository for the `# /` pattern. All detected instances were found to be either placeholders for documentation purposes (e.g., `# /sc:command-name`) or markdown headings, not accidentally disabled commands. Conclusion: The repository is in a clean and intentional state. The file deletions were part of a planned migration, and there are no inadvertently commented-out commands.
|
Hey @Utakata what do you think about creating the new repo for this plugin |
|
Thanks for the review! agree with your suggestion. Separating the repositories will indeed make it easier to manage compatibility and versioning between the framework and the plugin. I'll proceed in that direction. |
|
@Utakata i sent you an invitation to repo go ahead and work on it feel free to reach if anything else |
|
Got it, thank you so much! I really appreciate you setting that up for me; it feels very supportive. I've accepted the invitation and am excited to work on the new repo. |
|
@mithun50 Is the new repo public? Can't contribute, but would like to star it so I get the notice when it's ready to use and we can migrate. |
Should we use this instead of the current repo? Looking to reinstall as my context usage is too high currently |
|
Hi. And you be able to use also Plugin repo I already fix that issues. and I send PR this repo already. |
|
I hope, plugin system is applied to this Repo. |
|
@devstefancho I already confirmed working and fully tested on the next branch. please check this repo https://github.com/SuperClaude-Org/SuperClaude_Plugin/tree/next |
|
If you can add me as a collaborator, I can refactor all features into the new plugin format. |
|
@kazukinakai |
chore: Investigate deleted files and commented commands
This commit is the result of an investigation task. No code changes were made.
The investigation was conducted to address two user concerns:
# /...).Findings:
Deleted Markdown Files: The mass deletion of files was an intentional part of the project's migration from a v3 architecture to the v4 Claude Code official plugin system, as documented in the README.md. The repository structure is consistent with the new v4 architecture.
Commented-out Commands: A thorough search was conducted across the entire repository for the
# /pattern. All detected instances were found to be either placeholders for documentation purposes (e.g.,# /sc:command-name) or markdown headings, not accidentally disabled commands.Conclusion: The repository is in a clean and intentional state. The file deletions were part of a planned migration, and there are no inadvertently commented-out commands.