Print an error if non-positive dt is detected #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print an error if non-positive dt is detected for the usual constructors of any of the integrators. There might be some internal use cases for negative dt; this can be achieved with a mutable update:
Also deprecate the
Base.copy(dyn::Langevin)
overload. For user code, the same can be achieved withdeepcopy(dyn)
. It's not clear we want to recommend that to users, though. See #193 for discussion.