Short circuiting mod1
to speed offsetc
#184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For systems with very simple interactions, wrapping indices to the system's periodic boundaries can absorb a significant chunk of the total simulation time. The culprit is the modulo operation (used as
mod1
in Julia). In the common case, the index will already be in-bounds, so no wrapping is needed. If this situation is detected, we can short-circuit themod1
operation and immediately return the original index. Doing so reduces the overhead for index-wrapping from 16% to about 8% of the total run-time in the dynamics benchmark below. It should also provide speedups for theLocalSampler
use-case.