You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
3c43a43 reintroduced a lot of allocations into the inner loop that actually slow things down, and partially reverting (keeping the change to q instead of q_absolute) made it fast enough for my code to run again.
Strangely, when I committed that same patch, I benchmarked a very large speedup. Test files attached. MgCr2O4-test.zip
The text was updated successfully, but these errors were encountered:
This resolves (#204). The solution is to pass `ntuple` the length statically as `Val{NAtoms}()`, rather than as a runtime value `Natoms`. This avoids reliance on compiler inlining.
1.27s after keeping3c43a43, and additionally applying the fix 90b9480.
That is, Sunny 0.5.9 will be 30% faster than any previous Sunny. The fix was to pass length information to ntuple statically, which avoids reliance on compiler inlining.
From @Lazersmoke:
Strangely, when I committed that same patch, I benchmarked a very large speedup. Test files attached.
MgCr2O4-test.zip
The text was updated successfully, but these errors were encountered: