address comments (uber#3248)

Sunkwan-Kwon · May 8, 2020 · df82425 · df82425
1 parent 4e025cf
commit df82425
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/common/persistence/domainReplicationQueue.go b/common/persistence/domainReplicationQueue.go
@@ -101,7 +101,7 @@ func (q *domainReplicationQueueImpl) Start() {
 }
 
 func (q *domainReplicationQueueImpl) Stop() {
-	if !atomic.CompareAndSwapInt32(&q.status, common.DaemonStatusInitialized, common.DaemonStatusStopped) {
+	if !atomic.CompareAndSwapInt32(&q.status, common.DaemonStatusStarted, common.DaemonStatusStopped) {
 		return
 	}
 	close(q.done)

diff --git a/service/frontend/adminHandler.go b/service/frontend/adminHandler.go
@@ -118,12 +118,14 @@ func (adh *AdminHandler) RegisterHandler() {
 func (adh *AdminHandler) Start() {
 	// Start domain replication queue cleanup
 	if adh.config.EnableCleanupReplicationTask() {
+		// If the queue does not start, we can still call stop()
 		adh.Resource.GetDomainReplicationQueue().Start()
 	}
 }
 
 // Stop stops the handler
 func (adh *AdminHandler) Stop() {
+	// Calling stop if the queue does not start is ok
 	adh.Resource.GetDomainReplicationQueue().Stop()
 }