Added cloud storage services AWS and GCP #1590
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| export SPARK_PUBLIC_DNS="{{ spark.public_dns }}" | ||
| export reports_storage_key={{sunbird_private_storage_account_name}} | ||
| export reports_storage_secret={{sunbird_private_storage_account_key}} | ||
| export azure_storage_key={{sunbird_private_storage_account_name}} |
There was a problem hiding this comment.
Please don't change the internal variables
There was a problem hiding this comment.
sunbird_private_storage_account_key and sunbird_public_storage_account_name is internal variable ? is it refered to common variable or not ?
| druid_postgres_user: "{{ druid_postgres_user | default('druid@' + postgres.db_url) }}" | ||
| #Druid Azure Details | ||
| druid_postgres_pass: "{{ dp_vault_druid_postgress_pass }}" | ||
| azure_account_name: "{{ sunbird_druid_storage_account_name }}" |
There was a problem hiding this comment.
sunbird_druid_storage_account_name is this an internal variable or a common variable?
| "-Dfs.azure.account.key.{{ .Values.azure_storage_account }}.blob.core.windows.net: {{ .Values.azure_storage_secret }}", | ||
| {{- end }} | ||
| {{- if eq .Values.checkpoint_store_type "aws" }} | ||
| "-Ds3.access-key={{ .Values.s3_access_key }}", |
There was a problem hiding this comment.
s3_access_key is it refering the cloud_storage_key ?
| {{- end }} | ||
| {{- if eq .Values.checkpoint_store_type "gcloud" }} | ||
| "-Dfs.gs.auth.client.id={{ .Values.gcloud_client_key }}", | ||
| "-Dfs.gs.auth.client.secret={{ .Values.gcloud_private_secret }}", |
There was a problem hiding this comment.
Same here as well. gcloud_client_key is this variable referring to cloud_storage_key
| export reports_storage_secret={{sunbird_private_storage_account_key}} | ||
| export azure_storage_key={{sunbird_private_storage_account_name}} | ||
| export azure_storage_secret={{sunbird_private_storage_account_key}} | ||
| export cloud_private_storage_accountname={{sunbird_private_storage_account_name}} |
There was a problem hiding this comment.
sunbird_private_storage_account_name do we have this variable?
| export SPARK_WORKER_INSTANCES={{ spark.worker.instances }} | ||
| export SPARK_EXECUTOR_MEMORY={{ spark.executor.memory }} | ||
| export SPARK_PUBLIC_DNS="{{ spark.public_dns }}" | ||
| export reports_storage_key={{sunbird_private_storage_account_name}} |
There was a problem hiding this comment.
sunbird_private_storage_account_name do we have this variable as well ?
| sbin_path: "{{ analytics_user_home }}/sbin" | ||
| azure_container_name: "{{secor_azure_container_name}}" | ||
| azure_account_key: "{{sunbird_private_storage_account_key}}" | ||
| cloud_storage_telemetry_bucketname: "{{secor_azure_container_name}}" |
There was a problem hiding this comment.
secor_azure_container_name do we have this variable ?
|
@SadanandGowda - Don't change the keys. Just update the values to private repository variables. |
2 participants
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please choose appropriate options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: