Disallow changing a user's email address #764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikAtSumo
force-pushed
the
erikatsumo-user-forcenew
branch
from
7b66e68 to
24ec980
Compare
ErikAtSumo
force-pushed
the
erikatsumo-user-forcenew
branch
3 times, most recently
from
d8b1ab6 to
0e2764d
Compare
ErikAtSumo
force-pushed
the
erikatsumo-user-forcenew
branch
from
0e2764d to
488b9d2
Compare
ErikAtSumo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for updating a user does not allow the email address to be modified. If someone tries to modify the email of a sumologic_user, then the provider will silently "pass", without making the desired change.
The new behavior informs the user that the email address may not be changed.
Closes #671
Note that #671 requests
ForceNew: truefor a user's email. I discussed with Kevin, and we agree that recreating a user unintentionally can have adverse consequences, so it's safer to just stop the operation.