Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename from pod_name/container_name to pod/container #19

Merged
merged 2 commits into from
May 2, 2019

Conversation

bin3377
Copy link

@bin3377 bin3377 commented May 2, 2019

relabel pod to pod_name, container to container_name
https://jira.kumoroku.com/jira/browse/SUMO-109075
FYI - @frankreno @lei-sumo

@bin3377 bin3377 requested a review from samjsong May 2, 2019 16:37
@frankreno
Copy link
Contributor

@bin3377 we should go the other direction, rename pod_name -> pod and container_name->container as this is the direction the sig insturmentation is moving to to stanardize - kubernetes/kubernetes#69099

@bin3377 bin3377 changed the title rename to pod_name, container_name rename from pod_name/container_name to pod/container May 2, 2019
@bin3377 bin3377 merged commit 5e668c8 into master May 2, 2019
@bin3377 bin3377 deleted the byi-rename-container-pod branch May 2, 2019 22:43
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
adding output for endpoints and source category by collector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants