Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sophos-central-source.md #3173

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update sophos-central-source.md #3173

merged 3 commits into from
Oct 6, 2023

Conversation

keyur-sumo
Copy link
Contributor

Purpose of this pull request

This pull request (PR) ...

Issue number:

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 5, 2023
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Oct 5, 2023

@kimsauce, when I ran yarn to preview this PR, it gave me raw-loader errors:

Module not found: Error: Can't resolve 'raw-loader' in '/Users/jpipkin/Documents/GitHub/forks/keyur-sumo/sumologic-documentation/docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework'
Module not found: Error: Can't resolve 'raw-loader' in '/Users/jpipkin/Documents/GitHub/forks/keyur-sumo/sumologic-documentation/docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework'
Module not found: Error: Can't resolve 'raw-loader' in '/Users/jpipkin/Documents/GitHub/forks/keyur-sumo/sumologic-documentation/docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework'
Module not found: Error: Can't resolve 'raw-loader' in '/Users/jpipkin/Documents/GitHub/forks/keyur-sumo/sumologic-documentation/docs/send-data/hosted-collectors/cloud-to-cloud-integration-framework'
client (webpack 5.80.0) compiled with 4 errors

I had to run yarn add raw-loader so I could successfully do a local build for the patch-3 branch.

How should we handle these situations when they come up? Should we just go ahead and commit the updated yarn.lock file that results from running yarn add raw-loader? Or should we tell the PR submitter to run yarn install (and would that fix it)?

@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Oct 5, 2023
@JV0812
Copy link
Collaborator

JV0812 commented Oct 5, 2023

@jpipkin1 This error is due to the addition of new components in our new C2C source. Before building you can just run the below command to instal the packages related to raw-loader.
yarn add raw-loader

Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix

@keyur-sumo keyur-sumo requested a review from JV0812 October 6, 2023 05:38
@keyur-sumo
Copy link
Contributor Author

@JV0812 fix is made. can you please re-review?

Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label Oct 6, 2023
@JV0812 JV0812 enabled auto-merge October 6, 2023 05:51
@JV0812 JV0812 added this pull request to the merge queue Oct 6, 2023
Merged via the queue into SumoLogic:main with commit d92b034 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants