Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New SIGNL4 alerting article #3145

Merged
merged 8 commits into from
Oct 3, 2023
Merged

New SIGNL4 alerting article #3145

merged 8 commits into from
Oct 3, 2023

Conversation

jpipkin1
Copy link
Collaborator

@jpipkin1 jpipkin1 commented Oct 2, 2023

Purpose of this pull request

This pull request (PR) adds a new SIGNL4 alerting article originally submitted by @rons4 in PR #3142. It adds this article:
https://help.sumologic.com/docs/alerts/webhook-connections/signl4

Issue number: #3111

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@jpipkin1 jpipkin1 added the doc:new New section or topic to content label Oct 2, 2023
@jpipkin1 jpipkin1 requested a review from kimsauce as a code owner October 2, 2023 17:50
@jpipkin1 jpipkin1 self-assigned this Oct 2, 2023
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 2, 2023
@jpipkin1 jpipkin1 mentioned this pull request Oct 2, 2023
Closed
3 tasks
kimsauce
kimsauce requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

jpipkin1 and others added 3 commits October 3, 2023 08:26
@jpipkin1 @kimsauce
Update docs/alerts/webhook-connections/signl4.md
c65d3f8 
Co-authored-by: Kim <56411016+kimsauce@users.noreply.github.com>
@jpipkin1 @kimsauce
Update docs/alerts/webhook-connections/signl4.md
d29075f 
Co-authored-by: Kim <56411016+kimsauce@users.noreply.github.com>
@jpipkin1 @kimsauce
Update docs/alerts/webhook-connections/signl4.md
07f1650 
Co-authored-by: Kim <56411016+kimsauce@users.noreply.github.com>
@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Oct 3, 2023

Thanks for the review, @kimsauce. I committed your suggestions.

@jpipkin1 jpipkin1 enabled auto-merge October 3, 2023 13:27
@jpipkin1 jpipkin1 added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 6c97559 Oct 3, 2023
@jpipkin1 jpipkin1 deleted the new-signl4-alerting-article branch October 3, 2023 19:10
@jpipkin1 jpipkin1 mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimsauce kimsauce kimsauce approved these changes

@stacykor stacykor Awaiting requested review from stacykor

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

Assignees

@jpipkin1 jpipkin1

Labels
cla-signed Contributor approved, listed in .clabot file doc:new New section or topic to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpipkin1 @kimsauce