Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure docs only apps changes #3115

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Azure docs only apps changes #3115

merged 11 commits into from
Sep 27, 2023

Conversation

himanshu219
Copy link
Collaborator

@himanshu219 himanshu219 commented Sep 26, 2023 •
edited
Loading

Purpose of this pull request

This pull request (PR) creates new documentation for 16 azure doc only apps.

Issue number:

SUMO-226480

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 26, 2023
@himanshu219 himanshu219 added doc:new New section or topic to content do-not-merge Pull requests that should not be merged hot🔥 urgent release - prioritize labels Sep 26, 2023
JV0812
JV0812 reviewed Sep 26, 2023
View reviewed changes
docs/integrations/microsoft-azure/azure-application-gateway.md Outdated

### HTTP Logs and Metrics Source used by Azure Application Gateway

Follow the instructions in [Collect Metrics from Azure Monitor > Troubleshooting metrics collection](/docs/send-data/collect-from-other-data-sources/azure-monitoring/collect-metrics-azure-monitor/#troubleshooting-metrics-collection).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence looks incomplete, Can you write about, why we need to follow these instructions?

JV0812
JV0812 requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix. Can you please check and rectify the repeated errors.

@himanshu219 himanshu219 removed the hot🔥 urgent release - prioritize label Sep 26, 2023
@himanshu219 himanshu219 requested a review from JV0812 September 27, 2023 11:40
JV0812
JV0812 requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting changes

docs/integrations/microsoft-azure/azure-batch.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-batch.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-batch.md Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-application-gateway.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-application-gateway.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-synapse-analytics.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-synapse-analytics.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-virtual-network.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-virtual-network.md Outdated Show resolved Hide resolved
docs/integrations/microsoft-azure/azure-virtual-network.md Outdated Show resolved Hide resolved
@himanshu219 @JV0812
Apply suggestions from code review
22d58a6 
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
@himanshu219 himanshu219 requested a review from JV0812 September 27, 2023 13:11
JV0812
JV0812 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himanshu219 himanshu219 added this pull request to the merge queue Sep 27, 2023
@himanshu219 himanshu219 removed the do-not-merge Pull requests that should not be merged label Sep 27, 2023
Merged via the queue into main with commit 9b2aad4 Sep 27, 2023
@himanshu219 himanshu219 deleted the hpal_azure_docs_set1 branch September 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JV0812 JV0812 JV0812 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@stacykor stacykor Awaiting requested review from stacykor

@jpipkin1 jpipkin1 Awaiting requested review from jpipkin1 jpipkin1 is a code owner

Assignees
No one assigned
Labels
cla-signed Contributor approved, listed in .clabot file doc:new New section or topic to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshu219 @JV0812