Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenable app doc #3068

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Tenable app doc #3068

merged 6 commits into from
Sep 13, 2023

Conversation

JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Sep 12, 2023

Purpose of this pull request

This pull request (PR) ...

Issue number:

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 12, 2023
@JV0812 JV0812 self-assigned this Sep 12, 2023
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Sep 12, 2023
jpipkin1
jpipkin1 requested changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812 the new article looks very good. The only issue I saw was for the dashboard images.

@JV0812
Copy link
Collaborator Author

JV0812 commented Sep 13, 2023

Thanks @jpipkin1, I have updated the URL and made them public in S3. It works for me now, can you check from your end.

@JV0812 JV0812 requested a review from jpipkin1 September 13, 2023 04:45
jpipkin1
jpipkin1 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812, the dashboard images now work for me. Thanks for fixing them!

@JV0812 JV0812 enabled auto-merge September 13, 2023 14:21
@JV0812 JV0812 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit b4521b6 Sep 13, 2023
@JV0812 JV0812 deleted the tenable-app-doc branch September 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitgoelcmu ankitgoelcmu ankitgoelcmu left review comments

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@stacykor stacykor Awaiting requested review from stacykor

Assignees

@JV0812 JV0812

Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JV0812 @ankitgoelcmu @jpipkin1