Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404s #3013

Merged
merged 13 commits into from
Aug 30, 2023
Merged

Fix 404s #3013

merged 13 commits into from
Aug 30, 2023

Conversation

kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Aug 30, 2023 •
edited
Loading

Purpose of this pull request

Added / to links where needed (caused 404s)

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@kimsauce kimsauce self-assigned this Aug 30, 2023
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Aug 30, 2023
@kimsauce
Copy link
Collaborator Author

Hi @jpipkin1 , would you be able to review this one at your convenience? You can ignore all the random space modifications caused by Atom/VS Code conversion lol

jpipkin1
jpipkin1 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @kimsauce!

Just curious. Why is it important to get rid of extra spaces at the end of lines?

@jpipkin1 jpipkin1 added this pull request to the merge queue Aug 30, 2023
@kimsauce
Copy link
Collaborator Author

kimsauce commented Aug 30, 2023 •
edited
Loading

Looks great, @kimsauce!

Just curious. Why is it important to get rid of extra spaces at the end of lines?

@jpipkin1 See my previous comment :D -- #3013 (comment)

@jpipkin1
Copy link
Collaborator

Oops! Missed that comment, @kimsauce! Thanks.

Merged via the queue into main with commit e294fc6 Aug 30, 2023
@jpipkin1 jpipkin1 deleted the 404s branch August 30, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@stacykor stacykor Awaiting requested review from stacykor

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

Assignees

@kimsauce kimsauce

Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimsauce @jpipkin1