-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp doc only app - Batch 1 #2978
Conversation
I added Google Cloud Bigtable to the left nav with this commit: "Add Bigtable app to sidebar". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumoanema, the Bigtable article is incomplete. It should follow this template: https://github.com/SumoLogic/sumologic-documentation/blob/main/docs/contributing/templates/partner-app.md
Could you take another pass at it? Take a look at other articles in the Google apps section for examples of how to write an app article:
https://help.sumologic.com/docs/integrations/google/
I'm placing this PR in draft mode until you have it ready for another review.
@kimsauce/ @jpipkin1 - the changes in this PR are for doc only apps. I have made the changes in the md file based on the feedback I got from @npande (who was working on AWS doc only apps and has merged the following docs : #2948) . Based on the same pattern I am doing it for GCP in this PR. Based on your feedback on the single md file here, I will add all the other md file to the same PR for other GCP doc only apps. |
Thanks for the clarification, @sumoanema. I apologize for not realizing that this article would be formatted like the ones in PR #2948. I'll adjust my reviews for these "doc only apps". |
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
index.md page will be updated once all the GCP integration docs are added, just to avoid the rework.
Purpose of this pull request
This pull request (PR) ...
Issue number:
Select the type of change: