Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp doc only app - Batch 1 #2978

Merged
merged 20 commits into from
Aug 29, 2023
Merged

gcp doc only app - Batch 1 #2978

merged 20 commits into from
Aug 29, 2023

Conversation

sumoanema
Copy link
Collaborator

Purpose of this pull request

This pull request (PR) ...

Issue number:

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@sumoanema sumoanema added the do-not-merge Pull requests that should not be merged label Aug 23, 2023
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Aug 23, 2023
@sumoanema sumoanema marked this pull request as ready for review August 24, 2023 08:00
@jpipkin1 jpipkin1 added the doc:new New section or topic to content label Aug 24, 2023
@jpipkin1
Copy link
Collaborator

I added Google Cloud Bigtable to the left nav with this commit: "Add Bigtable app to sidebar".

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumoanema, the Bigtable article is incomplete. It should follow this template: https://github.com/SumoLogic/sumologic-documentation/blob/main/docs/contributing/templates/partner-app.md

Could you take another pass at it? Take a look at other articles in the Google apps section for examples of how to write an app article:
https://help.sumologic.com/docs/integrations/google/

I'm placing this PR in draft mode until you have it ready for another review.

@jpipkin1 jpipkin1 marked this pull request as draft August 24, 2023 14:52
@sumoanema
Copy link
Collaborator Author

sumoanema commented Aug 25, 2023

@kimsauce/ @jpipkin1 - the changes in this PR are for doc only apps. I have made the changes in the md file based on the feedback I got from @npande (who was working on AWS doc only apps and has merged the following docs : #2948) . Based on the same pattern I am doing it for GCP in this PR. Based on your feedback on the single md file here, I will add all the other md file to the same PR for other GCP doc only apps.

@jpipkin1
Copy link
Collaborator

Thanks for the clarification, @sumoanema. I apologize for not realizing that this article would be formatted like the ones in PR #2948. I'll adjust my reviews for these "doc only apps".

sumoanema and others added 2 commits August 29, 2023 19:00
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
@sumoanema sumoanema requested a review from JV0812 August 29, 2023 13:38
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
index.md page will be updated once all the GCP integration docs are added, just to avoid the rework.

@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label Aug 29, 2023
@JV0812 JV0812 enabled auto-merge August 29, 2023 13:41
@JV0812 JV0812 added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 66fd5a8 Aug 29, 2023
@JV0812 JV0812 deleted the gcpdoconlydocs branch August 29, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file doc:new New section or topic to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants